Missing cases from SPI_result_code_string() - Mailing list pgsql-hackers

From Dean Rasheed
Subject Missing cases from SPI_result_code_string()
Date
Msg-id CAEZATCUg8V+K+GcafOPqymxk84Y_prXgfe64PDoopjLFH6Z0Aw@mail.gmail.com
Whole thread Raw
Responses Re: Missing cases from SPI_result_code_string()
List pgsql-hackers
Another one noticed from the MERGE RETURNING patch -- the switch
statement in SPI_result_code_string() is missing cases for
SPI_OK_TD_REGISTER and SPI_OK_MERGE.

The SPI_OK_TD_REGISTER case goes back all the way, so I suppose it
should be back-patched to all supported branches, though evidently
this is not something anyone is likely to care about.

The SPI_OK_MERGE case is perhaps a little more visible (e.g., execute
MERGE from PL/Perl using $rv = spi_exec_query() and then examine
$rv->{status}). It's also missing from the docs for SPI_Execute().
Having tested that it now works as expected, I don't think there's
much point in adding a regression test case for it though.

Regards,
Dean

Attachment

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: psql \watch 2nd argument: iteration count
Next
From: Peter Eisentraut
Date:
Subject: Re: meson: Non-feature feature options