Re: Does rewriteTargetListIU still need to add UPDATE tlist entries? - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: Does rewriteTargetListIU still need to add UPDATE tlist entries?
Date
Msg-id CAEZATCUY4FWFnxdLPZnCJmqfLpLcbKRePj9SrDueqe5J_tso7Q@mail.gmail.com
Whole thread Raw
In response to Re: Does rewriteTargetListIU still need to add UPDATE tlist entries?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Does rewriteTargetListIU still need to add UPDATE tlist entries?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, 26 Apr 2021 at 15:09, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Thanks for looking at that.  On reflection I think this must be so,
> because those rewriter mechanisms were designed long before we had
> trigger-updatable views, and rewriteTargetListIU has never added
> tlist items like this for any other sort of view.  So the ability
> to insert the original view output column has necessarily been there
> from the beginning.  This is just getting rid of a weird implementation
> difference between trigger-updatable views and other views.
>

FWIW, I had a look at this too and came to much the same conclusion,
so I think this is a safe change that makes the code a little neater
and more efficient.

Regards,
Dean



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: tab-complete for ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Next
From: Alvaro Herrera
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error