Re: Numeric multiplication overflow errors - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: Numeric multiplication overflow errors
Date
Msg-id CAEZATCUS5sJ7BAPLE6m=GaqisZoxY92+p2ZOjkrbJbtewzuwOw@mail.gmail.com
Whole thread Raw
In response to Re: Numeric multiplication overflow errors  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Numeric multiplication overflow errors  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Thu, 1 Jul 2021 at 10:27, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> I'll post an update in a while. Thanks for the review.
>

One other thing I'm wondering about is back-patching. I was originally
thinking of these as back-patchable bug fixes, but changing the binary
format of the aggregate serialization states feels dodgy for a
back-patch.

But then, these functions are only callable in an aggregate context,
and work in pairs. It could be a problem if someone were using them to
pass state between different servers, but I see no evidence of them
being used in that way.

For reference, this will affect the following:
 - int8_avg_serialize()
 - numeric_avg_serialize()
 - numeric_poly_serialize()
 - numeric_serialize()

and the corresponding *_deserialize functions.

Regards,
Dean



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: ECPG doesn't compile CREATE AS EXECUTE properly.
Next
From: Fabien COELHO
Date:
Subject: Re: [PATCH] pgbench: add multiconnect option