Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation) - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)
Date
Msg-id CAEYLb_XH0n6o1fstQjsEDDQ2dD3hsybTEKj1SfmZ5QrcqZLs5Q@mail.gmail.com
Whole thread Raw
In response to Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 27 March 2012 20:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I've committed the core-backend parts of this, just to get them out of
> the way.  Have yet to look at the pg_stat_statements code itself.

Thanks. I'm glad that we have that out of the way.

> I ended up choosing not to apply that bit.  I remain of the opinion that
> this behavior is fundamentally inconsistent with the general rules for
> assigning parse locations to analyzed constructs, and I see no reason to
> propagate that inconsistency further than we absolutely have to.

Fair enough.

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)
Next
From: Andres Freund
Date:
Subject: Re: Command Triggers patch v18