Re: tuplesort memory usage: grow_memtuples - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: tuplesort memory usage: grow_memtuples
Date
Msg-id CAEYLb_VHZAm4MB4QjEwGuq9QnmhnGe+4bMN976GZmBTVovS64g@mail.gmail.com
Whole thread Raw
In response to Re: tuplesort memory usage: grow_memtuples  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: tuplesort memory usage: grow_memtuples  (Greg Stark <stark@mit.edu>)
Re: tuplesort memory usage: grow_memtuples  (Peter Geoghegan <peter@2ndquadrant.com>)
Re: tuplesort memory usage: grow_memtuples  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 16 October 2012 14:24, Simon Riggs <simon@2ndquadrant.com> wrote:
> If you describe in detail that it is a heuristic and why that is
> proposed over other approaches that should be sufficient for future
> generations to read and understand.

I've done so, in the attached revision. Things have been simplified
somewhat too.

The same basic strategy for sizing the tuplesort memtuples array in
also exists in tuplestore. I wonder if we should repeat this there? I
suppose that that could follow later.

The patch will now been marked "ready for committer". Does this need
doc changes, in light of what is arguably a behavioural difference?
You only mentioned release notes.

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: embedded list
Next
From: Greg Stark
Date:
Subject: Re: tuplesort memory usage: grow_memtuples