Re: [PATCH 04/16] Add embedded list interface (header only) - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [PATCH 04/16] Add embedded list interface (header only)
Date
Msg-id CAEYLb_UO9u-7z8Nk=jw1ieZdcNNgFWmLd-izHs=BfrPUH0zqxA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH 04/16] Add embedded list interface (header only)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH 04/16] Add embedded list interface (header only)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 22 June 2012 01:04, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> This is nonsense.  There are at least three buildfarm machines running
> compilers that do not "pretend to be gcc" (at least, configure
> recognizes them as not gcc) and are not MSVC either.

So those three don't have medium to high degrees of compatibility with GCC?

> We ought to have more IMO, because software monocultures are dangerous.  Of
> those three, two pass the "quiet inline" test and one --- the newest of the three
> if I guess correctly --- does not.  So it is not the case that
> !USE_INLINE is dead code, even if you adopt the position that we don't
> care about any compiler not represented in the buildfarm.

I note that you said that it doesn't pass the "quiet inline" test, and
not that it doesn't support inline functions.

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH 04/16] Add embedded list interface (header only)
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_dump and dependencies and --section ... it's a mess