Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #15293: Stored Procedure Triggered by Logical Replication isUnable to use Notification Events - Mailing list pgsql-bugs

From Marc Dean
Subject Re: BUG #15293: Stored Procedure Triggered by Logical Replication isUnable to use Notification Events
Date
Msg-id CAEU75wAdO7_t6MzSqWxua4Cca+KKpuHYYz6txz=VgETX--yYvw@mail.gmail.com
Whole thread Raw
In response to Re: BUG #15293: Stored Procedure Triggered by Logical Replication isUnable to use Notification Events  (Andres Freund <andres@anarazel.de>)
Responses Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events
List pgsql-bugs
Tree view
If Sergei is correct, I would volunteer to work on the patch. I am completely new to the codebase but this issue affects me. According to the documentation for `ProcessCompletedNotifies()` it should be called just before going idle... so perhaps in src/backend/replication/logical/worker.c at the tail end of `apply_handle_commit`? Again.. just looking at the codebase today so if this is beyond beginner level I will assist w/ testing instead. 

On Tue, Jul 24, 2018 at 11:58 AM, Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2018-07-24 16:19:45 +0300, Sergei Kornilov wrote:
> I checked this bug and found reason: we do not notify backends about new events by call ProcessCompletedNotifies from logical worker.
> New notify from regular backend does call ProcessCompletedNotifies: send signal to all listen backends and found new events for youself.
> But i am not sure where is correct place for call ProcessCompletedNotifies in logical worker src/backend/replication/logical/worker.c and i can not provide patch.

Peter, Petr, this is the second report of this issue. Anything?

Greetings,

Andres Freund


pgsql-bugs by date:

Previous
From: Andres Freund
Date:
Subject: Re: BUG #15293: Stored Procedure Triggered by Logical Replication isUnable to use Notification Events
Next
From: Sergei Kornilov
Date:
Subject: Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events