Re: Add regression tests for ROLE (USER) - Mailing list pgsql-hackers

From Robins Tharakan
Subject Re: Add regression tests for ROLE (USER)
Date
Msg-id CAEP4nAznaKyEcxMrrsQ8RBvDOAeAXE5=V2AsfM8JpLORuCGaPQ@mail.gmail.com
Whole thread Raw
In response to Re: Add regression tests for ROLE (USER)  (Robins Tharakan <tharakan@gmail.com>)
Responses Re: Add regression tests for ROLE (USER)
List pgsql-hackers

On 6 July 2013 20:25, Robins Tharakan <tharakan@gmail.com> wrote:

Do let me know your view on this second point, so that I can remove these tests if so required.

Hi,

Please find attached the updated patch.

It address the first issue regarding reducing the repeated CREATE / DROP ROLEs.

It still doesn't address the excessive (syntactical) checks tough. I am still unclear as to how to identify which checks to skip. (As in, although I have a personal preference of checking everything, my question probably wasn't clear in my previous email. I was just asking 'how' to know which checks to not perform.) Should a 'syntax error' in the message be considered as an unnecessary check? If so, its easier for me to identify which checks to skip, while creating future tests.

--
Robins Tharakan
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Next
From: Andres Freund
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe