Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string - Mailing list pgsql-bugs

From Robins Tharakan
Subject Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string
Date
Msg-id CAEP4nAxvLVzvkt+ABBfd_yDhBJjhJnKqDXZorLf=VG-Yp23TmA@mail.gmail.com
Whole thread Raw
In response to Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-bugs

On Thu, 6 Mar 2025 at 17:13, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
On Tue, Mar 4, 2025 at 10:44 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> After sleeping on it, PFA a simplified version.

Running tests on v5 patch for a few hours was uneventful (which is good).

 
I think we don't need to even do palloc() for the buffer as we can use
the char[MAXPGPATH] instead. I've attached the patch to improve the
parse_snapshot_filename() function and add some regression tests.
Please review these changes.


I've updated that with this patch too. Will update if something comes up.

-
robins

pgsql-bugs by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string
Next
From: Bertrand Drouvot
Date:
Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string