Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe. - Mailing list pgsql-committers

From Robins Tharakan
Subject Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.
Date
Msg-id CAEP4nAxopRsH+NrzYtD597EESJV9hQPo=ORcYrnuK5HHFBd3Bg@mail.gmail.com
Whole thread Raw
In response to pgsql: doc: Warn that ts_headline() output is not HTML-safe.  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.
List pgsql-committers
Hi,

On Thu, 1 May 2025 at 19:43, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
doc: Warn that ts_headline() output is not HTML-safe.

Backpatch-through: 13


This commit looks harmless, but 2 separate machines are 
failing on this commit (at the same point).

For now, it appears more like a compiler bug. I have requested
a gcc account (to file a bug) but I wouldn't be surprised if these 
machines keep failing until that resolves (or until I fix a gcc 
compile flag etc).

(I'd expect v13 to fail soon too)

Pasting the error here, in case someone can point me to something 
I'm doing wrong, or else, I'll revert once I have an update from GCC.


postgres@dell:~/proj/postgres/src/backend/nodes$ gcc -v -save-temps -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-deprecated-non-prototype -Wno-format-truncation -Wno-stringop-truncation -g -O2 -std=gnu17 -I../../../src/include  -D_GNU_SOURCE -I/usr/include/libxml2   -c -o nodeFuncs.o nodeFuncs.c
Using built-in specs.
COLLECT_GCC=gcc
Target: x86_64-pc-linux-gnu
Configured with: /opt/gcc/source/configure --prefix=/opt/gcc/target --disable-multilib : (reconfigured) /opt/gcc/source/configure --prefix=/opt/gcc/target --disable-multilib : (reconfigured) /opt/gcc/source/configure --prefix=/opt/gcc/target --disable-multilib --enable-languages=c,c++,fortran,lto,objc --no-create --no-recursion
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 16.0.0 20250501 (experimental) (GCC)
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-Wall' '-Wmissing-prototypes' '-Wpointer-arith' '-Wdeclaration-after-statement' '-Werror=vla' '-Wendif-labels' '-Wsuggest-attribute=format' '-Wimplicit-fallthrough=3' '-Wcast-function-type' '-Wformat-security' '-fno-strict-aliasing' '-fwrapv' '-fexcess-precision=standard' '-Wno-deprecated-non-prototype' '-Wformat-truncation=0' '-Wno-stringop-truncation' '-g' '-O2' '-std=gnu17' '-I' '../../../src/include' '-D' '_GNU_SOURCE' '-I' '/usr/include/libxml2' '-c' '-o' 'nodeFuncs.o' '-mtune=generic' '-march=x86-64'
 /opt/gcc/prod/bin/../libexec/gcc/x86_64-pc-linux-gnu/16.0.0/cc1 -E -quiet -v -I ../../../src/include -I /usr/include/libxml2 -imultiarch x86_64-linux-gnu -iprefix /opt/gcc/prod/bin/../lib/gcc/x86_64-pc-linux-gnu/16.0.0/ -D _GNU_SOURCE nodeFuncs.c -mtune=generic -march=x86-64 -std=gnu17 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wsuggest-attribute=format -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -Wno-deprecated-non-prototype -Wformat-truncation=0 -Wno-stringop-truncation -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -fworking-directory -O2 -fpch-preprocess -o nodeFuncs.i
ignoring nonexistent directory "/opt/gcc/prod/bin/../lib/gcc/x86_64-pc-linux-gnu/16.0.0/include-fixed/x86_64-linux-gnu"
ignoring nonexistent directory "/opt/gcc/prod/bin/../lib/gcc/x86_64-pc-linux-gnu/16.0.0/../../../../x86_64-pc-linux-gnu/include"
ignoring duplicate directory "/opt/gcc/prod/bin/../lib/gcc/../../lib/gcc/x86_64-pc-linux-gnu/16.0.0/include"
ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu"
ignoring nonexistent directory "/opt/gcc/prod/bin/../lib/gcc/../../lib/gcc/x86_64-pc-linux-gnu/16.0.0/include-fixed/x86_64-linux-gnu"
ignoring duplicate directory "/opt/gcc/prod/bin/../lib/gcc/../../lib/gcc/x86_64-pc-linux-gnu/16.0.0/include-fixed"
ignoring nonexistent directory "/opt/gcc/prod/bin/../lib/gcc/../../lib/gcc/x86_64-pc-linux-gnu/16.0.0/../../../../x86_64-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 ../../../src/include
 /usr/include/libxml2
 /opt/gcc/prod/bin/../lib/gcc/x86_64-pc-linux-gnu/16.0.0/include
 /opt/gcc/prod/bin/../lib/gcc/x86_64-pc-linux-gnu/16.0.0/include-fixed
 /usr/local/include
 /opt/gcc/prod/bin/../lib/gcc/../../include
 /usr/include/x86_64-linux-gnu
 /usr/include
End of search list.
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-Wall' '-Wmissing-prototypes' '-Wpointer-arith' '-Wdeclaration-after-statement' '-Werror=vla' '-Wendif-labels' '-Wsuggest-attribute=format' '-Wimplicit-fallthrough=3' '-Wcast-function-type' '-Wformat-security' '-fno-strict-aliasing' '-fwrapv' '-fexcess-precision=standard' '-Wno-deprecated-non-prototype' '-Wformat-truncation=0' '-Wno-stringop-truncation' '-g' '-O2' '-std=gnu17' '-I' '../../../src/include' '-D' '_GNU_SOURCE' '-I' '/usr/include/libxml2' '-c' '-o' 'nodeFuncs.o' '-mtune=generic' '-march=x86-64'
 /opt/gcc/prod/bin/../libexec/gcc/x86_64-pc-linux-gnu/16.0.0/cc1 -fpreprocessed nodeFuncs.i -quiet -dumpbase nodeFuncs.c -dumpbase-ext .c -mtune=generic -march=x86-64 -g -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wsuggest-attribute=format -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -Wno-deprecated-non-prototype -Wformat-truncation=0 -Wno-stringop-truncation -std=gnu17 -version -fno-strict-aliasing -fwrapv -fexcess-precision=standard -o nodeFuncs.s
GNU C17 (GCC) version 16.0.0 20250501 (experimental) (x86_64-pc-linux-gnu)
        compiled by GNU C version 16.0.0 20250501 (experimental), GMP version 6.3.0, MPFR version 4.2.1, MPC version 1.3.1, isl version none
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 1595b8feb42ed5b4136e55368db04a28
nodeFuncs.c: In function ‘expression_tree_walker’:
nodeFuncs.c:1949:25: internal compiler error: Segmentation fault
 1949 |                         return walker(((WithCheckOption *) node)->qual, context);
      |                         ^~~~~~
0x263119f internal_error(char const*, ...)
        /opt/gcc/source/gcc/diagnostic-global-context.cc:517
0x1131fef crash_signal
        /opt/gcc/source/gcc/toplev.cc:321
0x75a3c964532f ???
        ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0xa30a1f tree_check(tree_node const*, char const*, int, char const*, tree_code)
        /opt/gcc/source/gcc/tree.h:3979
0xa30a1f fndecl_built_in_p(tree_node const*)
        /opt/gcc/source/gcc/tree.h:6922
0xa30a1f convert_arguments
        /opt/gcc/source/gcc/c/c-typeck.cc:4340
0xa30a1f build_function_call_vec(unsigned long, vec<unsigned long, va_heap, vl_ptr>, tree_node*, vec<tree_node*, va_gc, vl_embed>*, vec<tree_node*, va_gc, vl_embed>*, tree_node*)
        /opt/gcc/source/gcc/c/c-typeck.cc:3881
0xa7c194 c_parser_postfix_expression_after_primary
        /opt/gcc/source/gcc/c/c-parser.cc:13735
0xa58893 c_parser_postfix_expression
        /opt/gcc/source/gcc/c/c-parser.cc:13286
0xa5deaa c_parser_unary_expression
        /opt/gcc/source/gcc/c/c-parser.cc:10604
0xa5fb1b c_parser_cast_expression
        /opt/gcc/source/gcc/c/c-parser.cc:10445
0xa5ff0f c_parser_binary_expression
        /opt/gcc/source/gcc/c/c-parser.cc:10213
0xa61523 c_parser_conditional_expression
        /opt/gcc/source/gcc/c/c-parser.cc:9908
0xa61d24 c_parser_expr_no_commas
        /opt/gcc/source/gcc/c/c-parser.cc:9821
0xa62187 c_parser_expression
        /opt/gcc/source/gcc/c/c-parser.cc:13875
0xa629b7 c_parser_expression_conv
        /opt/gcc/source/gcc/c/c-parser.cc:13934
0xa556bd c_parser_statement_after_labels
        /opt/gcc/source/gcc/c/c-parser.cc:8226
0xa58541 c_parser_compound_statement_nostart
        /opt/gcc/source/gcc/c/c-parser.cc:7757
0xa8cad7 c_parser_compound_statement
        /opt/gcc/source/gcc/c/c-parser.cc:6975
0xa54029 c_parser_statement_after_labels
        /opt/gcc/source/gcc/c/c-parser.cc:8163
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.


-
robins

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Make escaping functions retain trailing bytes of an invalid char
Next
From: Tom Lane
Date:
Subject: Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.