[HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump - Mailing list pgsql-hackers

From Robins Tharakan
Subject [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump
Date
Msg-id CAEP4nAx22Z4ch74oJGzr5RyyjcyUSbpiFLyeYXX8pehfou92ug@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Hi,

Attached is a patch adds a --no-comments argument to pg_dump to skip generation of COMMENT statements when generating a backup. This is crucial for non-superusers to restore a database backup in a Single Transaction. Currently, this requires one to remove COMMENTs via scripts, which is inelegant at best.

A similar discussion had taken place earlier [1], however that stopped (with a Todo entry) since it required more work at the backend. 

This patch provides a stop-gap solution until then. If the feedback is to tackle this is by filtering comments for specific DB objects, an argument name (for e.g. --no-extension-comments or something) would help and I could submit a revised patch.

Alternatively, if there are no objections, I could submit this to the Commitfest.

References:

-
robins
​​
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: [HACKERS] Bug when dumping "empty" operator classes
Next
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] logical replication - still unstable after all thesemonths