Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id CAEG8a3La4=dnN1GxDQdrjLFSF=vnbKe8A7K79=YVPeZYOnLuWA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] eliminate duplicate code in table.c  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
btw, there are some typos in Patch v5, %s/ralation/relation/g

On Thu, Jul 21, 2022 at 10:05 PM Aleksander Alekseev
<aleksander@timescale.com> wrote:
>
> Hi Amit,
>
> > Yeah, that's better. On again thinking about the function name, I
> > wonder if validate_relation_type() suits here as there is no generic
> > object being passed?
>
> Yep, validate_relation_type() sounds better.
>
> --
> Best regards,
> Aleksander Alekseev



-- 
Regards
Junwang Zhao



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: shared-memory based stats collector - v70
Next
From: Amit Langote
Date:
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size