Postgres Pro
Downloads
Home   >   mailing lists

Re: Use RELATION_IS_OTHER_TEMP where possible - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: Use RELATION_IS_OTHER_TEMP where possible
Date
Msg-id CAEG8a3Ju5Z1hCGMAPir_vUErLPtn5rvQyMJNTkGG3H+tsFSspA@mail.gmail.com
Whole thread Raw
In response to Re: Use RELATION_IS_OTHER_TEMP where possible  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
List pgsql-hackers
Tree view 
Hi Ashutosh,

On Wed, Jun 11, 2025 at 7:11 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
>
>
> On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
>>
>> Hi Nathan,
>>
>> On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart
>> <nathandbossart@gmail.com> wrote:
>> >
>> > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote:
>> > > All other files perform this check using RELATION_IS_OTHER_TEMP.
>> > > Should we update tablecmds.c to do the same for consistency?
>> >
>> > Seems like a good idea.
>>
>> Thanks for the comment.
>>
>> I have attached a patch with the proposed changes.
>
>
> LGTM. I looked at other instances of is_localtemp, but none of them have (relation)->rd_rel->relpersistence ==
RELPERSISTENCE_TEMPthere. Your patch has covered all the existing ones. 

Thank you for the review and the additional check.

I have created a cf entry to track this.

https://commitfest.postgresql.org/patch/5815/

>
> --
> Best Wishes,
> Ashutosh Bapat



--
Regards
Junwang Zhao

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Possibly hard-to-read message
Next
From: Alexander Borisov
Date:
Subject: Re: Improve the performance of Unicode Normalization Forms.