On Fri, Aug 2, 2024 at 12:29 AM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> On Thu, 1 Aug 2024 at 16:56, Junwang Zhao <zhjwpku@gmail.com> wrote:
> > I post my daily used devcontainer config[2] , Jelte(ccd)
> > suggested that it might be a good idea we integrate the
> > config into postgres repo so that the barrier to entry for
> > new developers will be much lower.
>
> In my experience adding a devcontainer config has definitely made it
> easier for people to contribute to Citus. So thank you for working on
> this! This is not a full review, but an initial pass.
>
> > After diving into the container, the postCreateCommand.sh
> > will be automatically called, it will do some configurations
> > like git, perf, .vscode, core_pattern, etc. It also downloads
> > michaelpq's pg_plugins and FlameGraph.
>
> I think the .git settings don't fit well here, they are mostly aliases
> which are very much based on personal preference and not related to
> Postgres development. It seems better recommend users to use the
> devcontainer dotfiles support for this:
> https://code.visualstudio.com/docs/devcontainers/containers#_personalizing-with-dotfile-repositories
>
> > - pgindent
>
> It might make sense to install Tristan (ccd) his Postgres Hacker
> extension for vscode to make this a bit more userfriendly:
> https://marketplace.visualstudio.com/items?itemName=tristan957.postgres-hacker
Good to know, I will try this later.
--
Regards
Junwang Zhao
