Postgres Pro
Downloads
Home   >   mailing lists

Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown) - Mailing list pgsql-hackers

From Paul Guo
Subject Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
Date
Msg-id CAEET0ZGtybm-CsXkwQgtvryhRu4L258g3ECgeuAwWt=5a2dS_Q@mail.gmail.com
Whole thread Raw
In response to Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
List pgsql-hackers
Tree view
On 2019-Sep-20, Paul Guo wrote:

> The patch series failed on Windows CI. I modified the Windows build file to
> fix that. See attached for the v7 version.

Thanks.

Question about 0003.  If we specify --skip-clean-shutdown and the cluter
was not cleanly shut down, shouldn't we error out instead of trying to
press on?

pg_rewind would error out in this case, see sanityChecks().
Users are expected to clean up themselves if they use this argument.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Custom reloptions and lock modes
Next
From: Amit Kapila
Date:
Subject: Re: dropdb --force