On Wed, Jun 19, 2019 at 7:22 PM Paul Guo <pguo@pivotal.io> wrote: > I updated the patch to v3. In this version, we skip the error if copydir fails due to missing src/dst directory, > but to make sure the ignoring is legal, I add a simple log/forget mechanism (Using List) similar to the xlog invalid page > checking mechanism. Two tap tests are included. One is actually from a previous patch by Kyotaro in this > email thread and another is added by me. In addition, dbase_desc() is fixed to make the message accurate.
Hello Paul,
FYI t/011_crash_recovery.pl is failing consistently on Travis CI with this patch applied:
This failure is because the previous v3 patch does not align with a recent patch
commit 660a2b19038b2f6b9f6bcb2c3297a47d5e3557a8 Author: Noah Misch <noah@leadboat.com> Date: Fri Jun 21 20:34:23 2019 -0700 Consolidate methods for translating a Perl path to a Windows path.
My patch uses TestLib::real_dir which is now replaced with TestLib::perl2host in the above commit.
I've updated the patch to v4 to make my code align. Now the test passes in my local environment.
