Re: Create option to hide WITH OIDS=FALSE, if OID is disabled - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Create option to hide WITH OIDS=FALSE, if OID is disabled
Date
Msg-id CAECtzeWh0Fi__u6-NsOhqmZTuqRKO2pxtneZ7R6CEV78kggcyw@mail.gmail.com
Whole thread Raw
In response to Create option to hide WITH OIDS=FALSE, if OID is disabled  (Robins Tharakan <tharakan@gmail.com>)
Responses Re: Create option to hide WITH OIDS=FALSE, if OID is disabled
List pgadmin-hackers
2014-11-09 8:52 GMT+01:00 Robins Tharakan <tharakan@gmail.com>:
Hi,

This is a ping to check if adding this minor feature is okay.

When the SQL is generated in the ObjectBrowser->SQLPane (for a table), it adds OIDS = FALSE, by default. I think that for a while, this has been irrelevant (unless of course the table actually has OIDs enabled).

Hope its okay to add a Check box in Options->Browser->UI Miscellaneous (Show if OIDS = FALSE) that allows a user to disable this part of the SQL. 

To confirm, 
- OIDS = TRUE would also show up, irrespective of the value of this check-box
- For now, the Check-Box would be enabled by default

Let me know if this isn't a great idea.


It'd be better to not have the checkbox, and rely on the value of the default_with_oids GUC.


--

pgadmin-hackers by date:

Previous
From: Robins Tharakan
Date:
Subject: Create option to hide WITH OIDS=FALSE, if OID is disabled
Next
From: David G Johnston
Date:
Subject: Re: Create option to hide WITH OIDS=FALSE, if OID is disabled