Re: [BUGS] BUG #9652: inet types don't support min/max - Mailing list pgsql-hackers

From Asif Naeem
Subject Re: [BUGS] BUG #9652: inet types don't support min/max
Date
Msg-id CAEB4t-P-db7c_UFqFvSurz2DEGUDhWRbCsdK9c_kvJ1E137EFw@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] BUG #9652: inet types don't support min/max  (Haribabu Kommi <kommi.haribabu@gmail.com>)
Responses Re: [BUGS] BUG #9652: inet types don't support min/max
List pgsql-hackers
Thank you for sharing updated patch. With latest 9.5 source code, patch build is failing with following error message i.e.

/Applications/Xcode.app/Contents/Developer/usr/bin/make -C catalog schemapg.h
cd ../../../src/include/catalog && '/opt/local/bin/perl' ./duplicate_oids
3255
make[3]: *** [postgres.bki] Error 1
make[2]: *** [submake-schemapg] Error 2
make[1]: *** [all-backend-recurse] Error 2
make: *** [all-src-recurse] Error 2

New function is being added by following commit i.e.

commit b34e37bfefbed1bf9396dde18f308d8b96fd176c
Author: Robert Haas <rhaas@postgresql.org>
Date:   Thu Aug 14 12:09:52 2014 -0400
    Add sortsupport routines for text.
    This provides a small but worthwhile speedup when sorting text, at least
    in cases to which the sortsupport machinery applies.
    Robert Haas and Peter Geoghegan

It seems that you need to use another oid. Other than this patch looks good to me, please share updated patch and feel free to assign it to committer. Thanks.

Regards,
Muhammad Asif Naeem



On Tue, Aug 12, 2014 at 3:12 PM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote:
On Mon, Aug 4, 2014 at 3:22 PM, Asif Naeem <anaeem.it@gmail.com> wrote:
> Sorry for not being clear, above mentioned test is related to following doc (sgml) changes that seems not working as described i.e.
>
> Table 9-35. cidr and inet Functions
>
> FunctionReturn TypeDescriptionExampleResult
>
> max(inet, inet) inetlarger of two inet typesmax('192.168.1.5', '192.168.1.4')192.168.1.5
> min(inet, inet) inetsmaller of two inet typesmin('192.168.1.5', '192.168.1.4')192.168.1.4
>
> Can you please elaborate these sgml change ?

I thought of adding them for newly added "network" functions but
mistakenly I kept the names as max and min.
Anyway with your suggestion in the earlier mail, these changes are not required.

I removed these changes in the attached patch.
Thanks for reviewing the patch.

Regards,
Hari Babu
Fujitsu Australia

pgsql-hackers by date:

Previous
From: 土卜皿
Date:
Subject: Re: how to understand these macro defines such as ObjectIdAttributeNumber in sysattr.h?
Next
From:
Date:
Subject: Re: pg_receivexlog --status-interval add fsync feedback