Re: [HACKERS] pageinspect: Hash index support - Mailing list pgsql-hackers

From Ashutosh Sharma
Subject Re: [HACKERS] pageinspect: Hash index support
Date
Msg-id CAE9k0PnJ=ps6JELp8re0O7quqTJDLNw8nSn9gHaeHFWd7=NQag@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pageinspect: Hash index support  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] pageinspect: Hash index support  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
> I think you should just tighten up the sanity checking in the existing
> function _hash_ovflblkno_to_bitno rather than duplicating the code.  I
> don't think it's called often enough for one extra (cheap) test to be
> an issue.  (You should change the elog in that function to an ereport,
> too, since it's going to be a user-facing error message now.)

okay, I have taken care of above two points in the attached patch. Thanks.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Parameterization of partial path
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal