Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot() - Mailing list pgsql-hackers

From Ashutosh Sharma
Subject Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot()
Date
Msg-id CAE9k0P=FvcDswnSVtRpSyZMpcAWC=Gp=ifZ0HdfPaRQ=__LBtw@mail.gmail.com
Whole thread Raw
Responses Re: Passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot()  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Hi Andres, Hari, David,

In the latest PostgreSQL code, I could see that we are passing CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot() although it is not being used anywhere in that function. Could you please let me know if it has been done intentionally or it is just an overlook that needs to be corrected. AFAIU, CopyMultiInsertInfoNextFreeSlot() is just intended to return the next free slot available in the multi insert buffer and we already have that buffer stored in ResultRelInfo structure which is also being passed to that function so not sure what could be the purpose of passing CopyMultiInsertInfo structure as well. Please let me know if i am missing something here. Thank you.

--
With Regards,
Ashutosh Sharma

pgsql-hackers by date:

Previous
From: pavan95
Date:
Subject: Re: How to install login_hook in Postgres 10.5
Next
From: Tom Lane
Date:
Subject: Re: PANIC :Call AbortTransaction when transaction id is no normal