Downloads
Home   >   mailing lists

Re: amcheck support for BRIN indexes - Mailing list pgsql-hackers

From Arseniy Mukhin
Subject Re: amcheck support for BRIN indexes
Date
Msg-id CAE7r3MJfwYQq9LqVYJDB85XwuXPD1GPsys8HvnqLQT-uB7Z-nw@mail.gmail.com
Whole thread Raw
In response to Re: amcheck support for BRIN indexes  (Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

While reviewing gist amcheck patch [1] I realized that brin amcheck
also must check if current snapshot is OK with index indcheckxmin (as
btree, gist do it). Currently this check is contained in btree amcheck
code, but other AMs need it for heapallindexed as well, so I moved it
from btree to verify_common (0003 patch).

Also I returned a consistentFn approach in heapallindexed as it seems
more preferable. But it's not a big deal to return to the within_range
approach if needed.


[1]
https://www.postgresql.org/message-id/flat/41F2A10C-4577-413B-9140-BE81CCE04A60%40yandex-team.ru#dc22ff33596f63f554cc551958131cde


Best regards,
Arseniy Mukhin
Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Proposal: QUALIFY clause
Next
From: Corey Huinker
Date:
Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions