Re: [HACKERS] [PATCH] Improve geometric types - Mailing list pgsql-hackers

From Emre Hasegeli
Subject Re: [HACKERS] [PATCH] Improve geometric types
Date
Msg-id CAE2gYzzRW_P=3hMn3zwUq90fsaQRD5b8Fy3dpOa3h2vTfuaTwQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Improve geometric types  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
>     ! circle_contain_pt() does the following comparison and it
>       seems to be out of our current policy.
>
>       point_dt(center, point) <= radius
>
>       I suppose this should use FPle.
>
>       FPle(point_dt(center, point), radius)
>
>       The same is true of circle_contain_pt(), pt_contained_circle .

box_contain_point() also doesn't use the macros.  They are certainly
inconsistent, but I don't think it would be an improvement to make
them use the macros.  As we have discussed, there are many problems
with the current application of EPSILON.  I think we would be better
off not using the macros for none of the containment operators, but
this is out of my scope for now.

> # Sorry, that' all for today..

I am waiting the rest of your review to post the new versions.


pgsql-hackers by date:

Previous
From: Emre Hasegeli
Date:
Subject: Re: [HACKERS] [PATCH] Improve geometric types
Next
From: Amit Langote
Date:
Subject: Re: no partition pruning when partitioning using array type