Re: Line intersection point is wrong - Mailing list pgsql-bugs

From Emre Hasegeli
Subject Re: Line intersection point is wrong
Date
Msg-id CAE2gYzyPkT6A55EOqAeLCXKYmWs6_g3VVEt_fLp+nw5bQziUwA@mail.gmail.com
Whole thread Raw
In response to Re: Line intersection point is wrong  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
> ... also, a quick review of all the LINE-related code in geo_ops.c
> says that it's just *full* of bugs.  Aside from the issues already
> mentioned:
>
> line_recv fails to reject A=B=0
> line_perp can get division by zero
> silly coding in line_eq (A and B can't both be zero, no need to look at C)
> line_distance ignores l1->A, suspicious
> close_pl busted in same way as line_interpt_internal

I have tried to fix them.  Patch attached.

> close_ps ignores tmp->B, suspicious

I think we better throw this one away, and implement another one using
close_pl().

Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #14203: pgindent requires pg_bsd_indent 1.2, but only 1.3 available for download
Next
From: Emre Hasegeli
Date:
Subject: Re: Line intersection point is wrong