Re: wrapping in extended mode doesn't work well with default pager - Mailing list pgsql-hackers

From Emre Hasegeli
Subject Re: wrapping in extended mode doesn't work well with default pager
Date
Msg-id CAE2gYzyMrS7XarOKXke-Shuahs4FP2Yd5=d2wcHr_=iuG_2w9w@mail.gmail.com
Whole thread Raw
In response to wrapping in extended mode doesn't work well with default pager  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: wrapping in extended mode doesn't work well with default pager  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com>:
> Hello
>
> I am checking feature
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6513633b94173fc1d9e2b213c43f9422ddbf5faa
>
> It works perfect with pager "less", but it works badly with default "more"
>
> see attached screenshots, pls
>
> It is expected behave?

I do not think so. It looks broken with or without any pager when
border != 2. Your less configuration might be hiding the problem from you.

I think it is because of miscalculation of the width used by
the separators. Increasing this variable for border = 0 and 1 fixed
the problem, but it might not be the right fix. The patch without
regression test changes attached.

While looking at it, I found another problem. It seems to me, a minus sign
is missing after -[RECORD  ] when border = 1.

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Archive recovery won't be completed on some situation.
Next
From: Heikki Linnakangas
Date:
Subject: Re: Archive recovery won't be completed on some situation.