>> This is also effecting lseg ## box operator.
>
> Mmm.. It returns (1.5, 1.5) with the 0004 patch. It is surely a
> point on the second operand but I'm not sure it's right that the
> operator returns a specific point for two parallel segments.
I am changing it to return NULL, when they are parallel.
> I'd like to put comments on 0001 and 0004 only now:
>
> - Adding [LR]DELIM_L looks good but they should be described in
> the comment just above.
I will mention it on the new version.
> - I'm not sure the change of box_construct is good but currently
> all callers fits the new interface (giving two points, not
> four coordinates).
I tried to make things more consistent. The other constructors takes points.
> - close_lseg seems forgetting the case where the two given
> segments are crossing (and parallel).
I am re-implementing it covering those cases.
> - make_bound_box operates directly on the poly->boundbox. I'm
> afraid that such coding hinders compiers from using registers.
I am changing it back.
> This is a bit apart from this patch, it would be better if we
> could eliminate internal calls using DirectFunctionCall.
We don't seem to be able to fix all issues without doing that. I will
incorporate the change.
Thank you for your review. I will address your other email before
posting new versions.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
