Re: [PATCH] Improve geometric types - Mailing list pgsql-hackers

From Emre Hasegeli
Subject Re: [PATCH] Improve geometric types
Date
Msg-id CAE2gYzxSLekocQhyRXsTk7jJs4DNbH217L-vGbdjUnaaFFaayw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve geometric types  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
> This should fix it I guess, and it's how we deal with unused return
> values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it
> seems rather ugly with that. I'll wait for Emre's opinion ...

Assert() is the wrong thing to do in here.  Drawn-perpendicular lines
may not intersect because of precision loss.  We have to check it and
return NULL.  There a few of those that we crash, or return garbage,
or get NULL and fail in DirectFunctionCall()s.  The next patch
"line-fixes" fixes them.


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: partition tree inspection functions
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: patch to allow disable of WAL recycling