Re: [PATCH] Improve geometric types - Mailing list pgsql-hackers

From Emre Hasegeli
Subject Re: [PATCH] Improve geometric types
Date
Msg-id CAE2gYzw4K5zVViXDdCKg7ZNY2+47s1gg5Fd4g8xj5a86jQpLSQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve geometric types  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [PATCH] Improve geometric types
List pgsql-hackers
> The version number restriction isn't strictly needed.  I only
> suggested it because it'd match the #if that wraps the code that's
> actually using those macros, introduced by commit cec8394b5ccd.  That
> was presumably done because versions >= 1800 (= Visual Studio 2013)
> have their own definitions of isinf() and isnan(), and I guess that
> our definitions were probably breaking stuff on that compiler.

Now I understand what you mean.  win32_port.h defines isnan(x) as
_isnan(x) if (_MSC_VER < 1800).  It doesn't look right to have the
definition in here but not include <float.h> as _isnan() is coming
from there.  I am preparing an additional patch to add the include and
remove it from files where it is obviously put to work around this
problem.


pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: Recovery performance of standby for multiple concurrent truncateson large tables
Next
From: Peter Eisentraut
Date:
Subject: Re: Changing WAL Header to reduce contention duringReserveXLogInsertLocation()