Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal - Mailing list pgsql-hackers

From Vladimir Rusinov
Subject Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date
Msg-id CAE1wr-zZifGZEPwYLKJjo-yCuZQwHAa54nF8DoT7MU0Un_Buwg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers

On Tue, Jan 3, 2017 at 11:56 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
Yeah, let's make the life of users just easier if we can, without any
extension. Some people are likely going to forget to enable it anyway,
and some more don't like installing the package dedicated to contrib
modules.

I think I +1 on this.
I've did a github search on these function names and there is a lot of code that use them. E.g. there is 8.5k hits for pg_last_xlog_location; a lot of them a forks and copy-pastes, but still, that's quite a lot. Let's keep the aliases around for couple of versions after which hopefully a lot of the code will be updated.

After I'm done with a patch I can take a look if there's a way to mass-fill issues to affected projects on github (and maybe other hosting providers) and ask them to migrate to new function names. This is of course will not fix everything, but it would be a significant chunk. I suspect a lot of private tools/scripts borrow snippets from github as well.

--
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] proposal: session server side variables
Next
From: valeriof
Date:
Subject: Re: [HACKERS] Logical decoding - filtering tables