- errhint("pg_xlogfile_name_offset() cannot be executed during recovery."))); + errhint( + "pg_wal_file_name_offset() cannot be executed during recovery."))); I am not sure that there is any need to reformat this error hint.
Your patch includes useless diff noise in pg_proc.h. By that I mean the lines of pg_start_backup, pg_stop_backup, etc.
+/* Next OID: 6016 */ + I don't think you need that.
Reverted all of above.
src/test/perl/PostgresNode.pm has added recently a new method called lsn() that uses some of the WAL position functions. Their update is necessary as well for this patch.
Good catch. Changed those as well.
As there are two school of thoughts on this thread, keeping your patch with the compatibility table is the best move for now. Even if we end up by having a version without aliases, that will be just code to remove in the final version.
Indeed, it is trivial to kill aliases.
New version of the patch attached.
-- Vladimir Rusinov Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047
