WIP patch for Oid formatting in printf/elog strings - Mailing list pgsql-hackers

From Mark Dilger
Subject WIP patch for Oid formatting in printf/elog strings
Date
Msg-id CAE-h2TrbiH2e_NQJGBMzQ9Eg24i6pkSsa4E2YKWqjWz2PNru2A@mail.gmail.com
Whole thread Raw
Responses Re: WIP patch for Oid formatting in printf/elog strings  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
I found a few places in the code where a variable of
type Oid is printed using "%d" rather than "%u" and
changed them in the attached patch.

In src/backend/replication/logical/reorderbuffer.c,
circa line 2494, chunk_seq is of type Oid, but
ent->last_chunk_seq is of type int32, leading me
to question if perhaps the use of %d for chunk_seq
is correct, but the use of Oid for the type of chunk_seq
is in error.  If neither is in error, perhaps someone
can provide a short code comment explaining the
logic of the signed/unsigned discrepancy.

Thanks,

Mark Dilger

Attachment

pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching
Next
From: Alvaro Herrera
Date:
Subject: Re: WIP patch for Oid formatting in printf/elog strings