Re: WIP patch for Oid formatting in printf/elog strings - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: WIP patch for Oid formatting in printf/elog strings
Date
Msg-id CAE-h2Tp4wdu7DFR_skvi4Q3TBph94pu4m-Z8K=mxR8EBTY_rXw@mail.gmail.com
Whole thread Raw
In response to Re: WIP patch for Oid formatting in printf/elog strings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: WIP patch for Oid formatting in printf/elog strings  (Mark Dilger <hornschnorter@gmail.com>)
Re: WIP patch for Oid formatting in printf/elog strings  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Thu, Dec 11, 2014 at 12:12 PM, Tom Lane
<spandir="ltr"><<a href="mailto:tgl@sss.pgh.pa.us" target="_blank">tgl@sss.pgh.pa.us</a>></span> wrote:<br
/><blockquoteclass="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">MarkDilger <<a href="mailto:hornschnorter@gmail.com">hornschnorter@gmail.com</a>> writes:<br /> > The
attachedpatch changes the type of chunk_seq to int32,<br /> > rather than changing the %d formatting.  The other
changes<br/> > are the same as in the previous patch.<br /><br /></span>BTW, how are you finding these?  If it's
someautomated tool, what?<br /> (If you're finding them by hand, I'm in awe of your scan rate.)<br /><br />            
           regards, tom lane<br /></blockquote></div><br /></div><div class="gmail_extra">I've been advised to hoodwink
youand say that I have found them all<br />by hand.  Actually, I am changing the typedef in src/include/c.h and then<br
/>recompiling,and watching for compiler warnings telling me that I am<br /></div><div class="gmail_extra">passing a
uint64to a %d.  Of course, I get lots of warnings about<br /></div><div class="gmail_extra">passing a uint64 to a %u,
butI can filter through those easily enough.<br /><br /></div><div class="gmail_extra">Also, the macros in outfuncs.c
tendto complain in a similar way, and<br />I can check that output, too.<br /><br /></div><div
class="gmail_extra">mark<br/></div></div> 

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching
Next
From: David Johnston
Date:
Subject: Re: 9.5 release scheduling (was Re: logical column ordering)