Re: WIP patch for Oid formatting in printf/elog strings - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: WIP patch for Oid formatting in printf/elog strings
Date
Msg-id CAE-h2Tp4wdu7DFR_skvi4Q3TBph94pu4m-Z8K=mxR8EBTY_rXw@mail.gmail.com
Whole thread Raw
In response to Re: WIP patch for Oid formatting in printf/elog strings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: WIP patch for Oid formatting in printf/elog strings
Re: WIP patch for Oid formatting in printf/elog strings
List pgsql-hackers


On Thu, Dec 11, 2014 at 12:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Mark Dilger <hornschnorter@gmail.com> writes:
> The attached patch changes the type of chunk_seq to int32,
> rather than changing the %d formatting.  The other changes
> are the same as in the previous patch.

BTW, how are you finding these?  If it's some automated tool, what?
(If you're finding them by hand, I'm in awe of your scan rate.)

                        regards, tom lane

I've been advised to hoodwink you and say that I have found them all
by hand.  Actually, I am changing the typedef in src/include/c.h and then
recompiling, and watching for compiler warnings telling me that I am
passing a uint64 to a %d.  Of course, I get lots of warnings about
passing a uint64 to a %u, but I can filter through those easily enough.

Also, the macros in outfuncs.c tend to complain in a similar way, and
I can check that output, too.

mark

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching
Next
From: David Johnston
Date:
Subject: Re: 9.5 release scheduling (was Re: logical column ordering)