ClosePipeStream failure ignored in pg_import_system_collations - Mailing list pgsql-hackers

From Mark Dilger
Subject ClosePipeStream failure ignored in pg_import_system_collations
Date
Msg-id CAE-h2ToRCx5XC3nQqeNipqhTt9berCYVVEvM4vEfkTKUsk9S4Q@mail.gmail.com
Whole thread Raw
Responses Re: ClosePipeStream failure ignored in pg_import_system_collations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hackers,

I only see three invocations of ClosePipeStream in the sources.
In two of them, the return value is checked and an error is raised
if it failed.  In the third, the error (if any) is squashed.

I don't know if a pipe stream over "locale -a" could ever fail to
close, but it seems sensible to log an error if it does.

Thoughts?

mark



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: fsync failure in durable_unlink ignored in xlog.c?
Next
From: Andres Freund
Date:
Subject: Top-N sorts in EXPLAIN, row count estimates, and parallelism