Postgres Pro
Downloads
Home   >   mailing lists

Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch - Mailing list pgsql-hackers

From Soumyadeep Chakraborty
Subject Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch
Date
Msg-id CAE-ML+9_9EmKQgTzzypiXRk+1+XCm9mDs3o5wa0=8oEVmz_M=w@mail.gmail.com
Whole thread Raw
In response to Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch  (Andres Freund <andres@anarazel.de>)
Responses Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch
List pgsql-hackers
Tree view
Hey,

I completely agree, that was an important consideration.

I had some purely cosmetic suggestions:
1. Rename ExecComputeSlotInfo to eliminate the need for the asserts.
2. Extract return value to a bool variable for slightly better
readability.
3. Taking the opportunity to use TTS_IS_VIRTUAL.

v2 of patch set attached. The first two patches are unchanged, the cosmetic
changes are part of v2-0003-Some-minor-cosmetic-changes.patch.

--
Soumyadeep
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: contrib/bloom Valgrind error
Next
From: Michael Paquier
Date:
Subject: Re: Change atoi to strtol in same place