Postgres Pro
Downloads
Home   >   mailing lists

Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch - Mailing list pgsql-hackers

From Soumyadeep Chakraborty
Subject Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch
Date
Msg-id CAE-ML+9OKSN71+mHtfMD-L24oDp8dGTfaVjDU6U+j+FNAW5kRQ@mail.gmail.com
Whole thread Raw
In response to Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch  (Andres Freund <andres@anarazel.de>)
Responses Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch
List pgsql-hackers
Tree view
Hello Andres,

Thank you very much for reviewing my patch!

On Wed, Sep 25, 2019 at 1:02 PM Andres Freund <andres@anarazel.de> wrote:
> IOW, wherever ExecComputeSlotInfo() is called, we should only actually
> push the expression step, when ExecComputeSlotInfo does not determine
> that a) the slot is virtual, b) and fixed (i.e. guaranteed to always be
> the same type of slot).
>
> Does that make sense?

That is a great suggestion and I totally agree. I have attached a patch
that achieves this.

--
Soumyadeep
Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: partition routing layering in nodeModifyTable.c
Next
From: Soumyadeep Chakraborty
Date:
Subject: Re: Don't codegen deform code for virtual tuples in expr eval forscan fetch