Re: A micro-optimisation for ProcSendSignal() - Mailing list pgsql-hackers

From Soumyadeep Chakraborty
Subject Re: A micro-optimisation for ProcSendSignal()
Date
Msg-id CAE-ML+8mZfCFEnDuBFF-+-xpCOPVZxrPnJFbT7Ft5L_en4m84A@mail.gmail.com
Whole thread Raw
In response to Re: A micro-optimisation for ProcSendSignal()  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: A micro-optimisation for ProcSendSignal()
List pgsql-hackers
Hi Thomas,

You might have missed a spot to initialize SERIALIZABLE_XACT->pgprocno in
InitPredicateLocks(), so:

+ PredXact->OldCommittedSxact->pgprocno = INVALID_PGPROCNO;

Slightly tangential: we should add a comment to PGPROC.pgprocno, for more
immediate understandability:

+ int pgprocno; /* index of this PGPROC in ProcGlobal->allProcs */

Also, why don't we take the opportunity to get rid of SERIALIZABLEXACT->pid? We
took a stab. Attached is v2 of your patch with these changes.

Regards,
Ashwin and Deep

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: postgres_fdw - make cached connection functions tests meaningful
Next
From: Andy Fan
Date:
Subject: Re: UniqueKey on Partitioned table.