[pgadmin-hackers] Issue with SlickGrid - Mailing list pgadmin-hackers

From Joao Pedro De Almeida Pereira
Subject [pgadmin-hackers] Issue with SlickGrid
Date
Msg-id CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com
Whole thread Raw
Responses Re: [pgadmin-hackers] Issue with SlickGrid  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Hello Hackers,

While doing some changes to the Query Results we found out that there was a issue with Slick grid. 

The issue that we found was with the CellSelectModel, behaved differently when pressing Ctrl and Command(Mac). We created a PR with the change to changes the behavior of the plugin.

When this PR is applied to the SlickGrid library we need to apply it to the current version of SlickGrid that we have vendorized.
According to the libraries.txt file we are in version 2.2.4 of the library but a diff between our code and the libraries version 2.2.4 shows differences in the code.

Did we do any change to SlickGrid library that is vendorized? Or is just the information in libraries.txt that is incorrect?
Does anyone know any problem if we bump the version of SlickGrid to the newer version after the PR is applied?

Thanks
Joao

pgadmin-hackers by date:

Previous
From: Shirley Wang
Date:
Subject: Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4
Next
From: Ashesh Vashi
Date:
Subject: Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4