Re: [pgadmin-hackers][patch] Move to Alembic migration system - Mailing list pgadmin-hackers
Hello Ashesh,
Did you had time to review this patch?
Thanks
Joao & Oliver
On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear <smcalear@pivotal.io> wrote:
Great, thank you so much!On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Hackers!Hi Sarah,Is there an update on this?We will look in to it end of this week.I was not rushing to it, because - Dave was preparing for the 1.4 release.-- Thanks, AsheshThanks,Sarah & JoaoOn Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/co mmand.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/sc ript/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_.p y", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: