Re: [sepgsql 2/3] Add db_schema:search permission checks - Mailing list pgsql-hackers

From Kohei KaiGai
Subject Re: [sepgsql 2/3] Add db_schema:search permission checks
Date
Msg-id CADyhKSWUXgGJhUXwixCz-u9COb6ig1Usud3R_THVrtVk8N8jOQ@mail.gmail.com
Whole thread Raw
In response to Re: [sepgsql 2/3] Add db_schema:search permission checks  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [sepgsql 2/3] Add db_schema:search permission checks
List pgsql-hackers
2013/4/12 Robert Haas <robertmhaas@gmail.com>:
> On Fri, Apr 12, 2013 at 10:42 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
>> Robert Haas escribió:
>>> On Mon, Apr 8, 2013 at 12:28 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
>>
>>> > Also, the attached function-execute-permission patch is a rebased
>>> > version. I rethought its event name should be OAT_FUNCTION_EXECUTE,
>>> > rather than OAT_FUNCTION_EXEC according to the manner without
>>> > abbreviation. Other portion is same as previous ones.
>>>
>>> Great.  This looks fine to me, committed.  I also committed your
>>> getObjectIdentity patch, which caused some regression test output
>>> changes.  I applied the necessary correction before committing, I
>>> think, but please check.
>>
>> I think the function-execute code path is still using
>> getObjectDescription rather than identity.
>
> Yeah, I think so.  KaiGai, can you provide a follow-on patch to fix that?
>
Yes, of course. The attached one replaces the getObjectDescription in
sepgsql/proc.c, and relative changes in regression test.

Thanks,
--
KaiGai Kohei <kaigai@kaigai.gr.jp>

Attachment

pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: (auto)vacuum truncate exclusive lock
Next
From: Kohei KaiGai
Date:
Subject: Re: [sepgsql 2/3] Add db_schema:search permission checks