Re: 64-bit API for large object - Mailing list pgsql-hackers

From Kohei KaiGai
Subject Re: 64-bit API for large object
Date
Msg-id CADyhKSVs318QeXwyRQdJ7DgzgOzgTmYa89EaWh=B8nnNFhtebA@mail.gmail.com
Whole thread Raw
In response to Re: 64-bit API for large object  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: 64-bit API for large object  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
> I think Tom's point is, there are tons of applications which define
> their own "int64_t" (at least in 2005).
> Also pg_config.h has:
>
> #define HAVE_STDINT_H   1
>
> and this suggests that PostgreSQL adopts to platforms which does not
> have stdint.h. If so, we need to take care of such platforms anyway.
>
OK, it makes me clear. It might be helpful a source code comment
to remain why we used self defined datatype here.

2012/9/21 Tom Lane <tgl@sss.pgh.pa.us>:
> Tatsuo Ishii <ishii@postgresql.org> writes:
>> To pass 64-bit integer to PQfn, PQArgBlock is used like this: int *ptr
>> is a pointer to 64-bit integer and actual data is placed somewhere
>> else.
>
> Yeah, I think we have to do it like that.  Changing the size of
> PQArgBlock would be a libpq ABI break, which IMO is sufficiently painful
> to kill this whole proposal.  Much better a little localized ugliness
> in fe-lobj.c.
>
Hmm, I see. Please deliver the 64bit integer argument as reference,
and don't forget endian translations here.

Thanks,
-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: xlog filename formatting functions in recovery
Next
From: Yugo Nagata
Date:
Subject: Re: 64-bit API for large object