Re: ALTER command reworks - Mailing list pgsql-hackers

From Kohei KaiGai
Subject Re: ALTER command reworks
Date
Msg-id CADyhKSV_gbTKy71EdxT-9PqyuVHOJ7phcf+yTJ47ZuNV7OhUDw@mail.gmail.com
Whole thread Raw
In response to Re: ALTER command reworks  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: ALTER command reworks  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
2013/1/15 Alvaro Herrera <alvherre@2ndquadrant.com>:
> Kohei KaiGai escribió:
>
>> The attached patch is a rebased version towards the latest master
>> branch, and fix up the issue around error messages on name conflicts.
>
> I assume the lock.c changes are just a bollixed merge, right?
>
Yes, I'll check it and rebase it.

> I am not sure about some of the changes in the regression test expected
> output; are we really okay with losing the "in schema foo" part in some
> of these cases?
>
The changes in the expected results in regression test originated from
elimination of getObjectDescription, but "in schema foo" should be kept.
It looks like an obvious my mistake. Sorry.

Thanks,
--
KaiGai Kohei <kaigai@kaigai.gr.jp>



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: logical changeset generation v4
Next
From: Andres Freund
Date:
Subject: Re: logical changeset generation v4