Re: Kudos for Reviewers -- straw poll - Mailing list pgsql-hackers

From Brendan Jurd
Subject Re: Kudos for Reviewers -- straw poll
Date
Msg-id CADxJZo3xevCTdv=0VWuXsbSyxY6o7b2JBpq59VLFuJzmOHOAmQ@mail.gmail.com
Whole thread Raw
In response to Kudos for Reviewers -- straw poll  (Josh Berkus <josh@agliodbs.com>)
Responses Re: Kudos for Reviewers -- straw poll  (David Johnston <polobo@yahoo.com>)
Re: Kudos for Reviewers -- straw poll  (Bruce Momjian <bruce@momjian.us>)
Re: Kudos for Reviewers -- straw poll  (gabrielle <gorthx@gmail.com>)
List pgsql-hackers
On 26 June 2013 03:17, Josh Berkus <josh@agliodbs.com> wrote:
> How should reviewers get credited in the release notes?
>
> a) not at all
> b) in a single block titled "Reviewers for this version" at the bottom.
> c) on the patch they reviewed, for each patch

A weak preference for (c), with (b) running a close second.  As others
have suggested, a review that leads to significant commitable changes
to the patch should bump the credit to co-authorship.

> Should there be a criteria for a "creditable" review?
>
> a) no, all reviews are worthwhile
> b) yes, they have to do more than "it compiles"
> c) yes, only code reviews should count

(b), the review should at least look at usabililty, doc, and
regression test criteria even if there is no in-depth code analysis.

> Should reviewers for 9.4 get a "prize", such as a t-shirt, as a
> promotion to increase the number of non-submitter reviewers?
>
> a) yes
> b) no
> c) yes, but submitters and committers should get it too

Provisionally (b), if we first try giving proper credit, and that
still doesn't drum up enough reviewing, then look to further incentive
schemes.  No need to jump the gun.

Cheers,
BJ



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Review: UNNEST (and other functions) WITH ORDINALITY
Next
From: Claudio Freire
Date:
Subject: Re: Hash partitioning.