Re: Question about some changes in 11.3 - Mailing list pgsql-hackers

From Mat Arye
Subject Re: Question about some changes in 11.3
Date
Msg-id CADsUR0Dx=bXcmSxDWtzO8WG24JFGkTHzBb9HZmQt4x8uOZaXuw@mail.gmail.com
Whole thread Raw
In response to Question about some changes in 11.3  (Mat Arye <mat@timescale.com>)
Responses Re: Question about some changes in 11.3
List pgsql-hackers
On Fri, May 24, 2019 at 5:05 PM Mat Arye <mat@timescale.com> wrote:
Hi,

11.3 included some change to partition table planning. Namely commit 925f46f ("Fix handling of targetlist SRFs when scan/join relation is known empty.") seems to redo all paths for partitioned tables in apply_scanjoin_target_to_paths. It clears the paths in:

```
 if (rel_is_partitioned)
        rel->pathlist = NIL 
```

Then the code rebuild the paths. However, the rebuilt append path never gets the
set_rel_pathlist_hook called. Thus, the work that hook did previously gets thrown away and the rebuilt append path can never be influenced by this hook. Is this intended behavior? Am I missing something?

Thanks,
Mat
TimescaleDB

I've  attached a small patch to address this discrepancy for when the set_rel_pathlist_hook is called so that's it is called for actual paths used for partitioned rels. Please let me know if I am misunderstanding how this should be handled.
 
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Next
From: Andres Freund
Date:
Subject: Re: PG 12 draft release notes