Re: psql metaqueries with \gexec - Mailing list pgsql-hackers

I'm getting a warning from this patch:

1 warning generated.

(note that I'm using CC='ccache clang -Qunused-arguments -fcolor-diagnostics')

        for (r = 0; r < nrows; r++)
        {
                for (c = 0; c < ncolumns; c++)
                {

etc...

Normally we don't use gratuitous {'s, and I don't think it's helping anything in this case. But I'll let whoever commits this decide.

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 5f27120..0f87f29 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -1280,8 +1280,8 @@ psql_completion(const char *text, int start, int end)
                "\\dm", "\\dn", "\\do", "\\dO", "\\dp", "\\drds", "\\ds", "\\dS",
                "\\dt", "\\dT", "\\dv", "\\du", "\\dx", "\\dy",
                "\\e", "\\echo", "\\ef", "\\encoding", "\\ev",
-               "\\f", "\\g", "\\gset", "\\h", "\\help", "\\H", "\\i", "\\ir", "\\l",
-               "\\lo_import", "\\lo_export", "\\lo_list", "\\lo_unlink",
+               "\\f", "\\g", "\\gexec", "\\gset", "\\h", "\\help", "\\H", "\\i", "\\ir",
+               "\\l", "\\lo_import", "\\lo_export", "\\lo_list", "\\lo_unlink",

FWIW, it's generally better to leave that kind of re-wrapping to the next pg_indent run.

I added tests for ON_ERROR_STOP. New patch attached.

The patch still needs to document this feature in the psql docs (and maybe the manpage? not sure how that's generated...)