Postgres Pro
Downloads
Home   >   mailing lists

Re: dblink: add polymorphic functions. - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: dblink: add polymorphic functions.
Date
Msg-id CADkLM=fQd56TKfciHHsfoBmoSnLyUuZjMBLh4Nc2eKywGBw=GQ@mail.gmail.com
Whole thread Raw
In response to Re: dblink: add polymorphic functions.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: dblink: add polymorphic functions.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view
I seem to be getting tripped up in the regression test. This line was found in regression.diff

+ ERROR:  could not stat file "/home/ubuntu/src/postgres/contrib/dblink/tmp_check/install/usr/local/pgsql/share/extension/dblink--1.2.sql": No such file or directory

The file dblink--1.2.sql does exist in /home/ubuntu/src/postgres/contrib/dblink/

~/src/postgres/contrib/dblink$ ls -la dblink--1.?.sql
-rw-rw-r-- 1 ubuntu ubuntu 5.7K Feb 22 16:02 dblink--1.1.sql
-rw-rw-r-- 1 ubuntu ubuntu 6.8K Feb 22 16:50 dblink--1.2.sql

But it evidently isn't making it into the tmp_check dir.

What needs to happen for new files to be seen by the regression test harness?


On Fri, Feb 20, 2015 at 1:14 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Fri, Feb 20, 2015 at 2:50 PM, Corey Huinker <corey.huinker@gmail.com> wrote:
> Thanks - completely new to this process, so I'm going to need
> walking-through of it. I promise to document what I learn and try to add
> that to the commitfest wiki. Where can I go for guidance about documentation
> format and regression tests?

Here are some guidelines about how to submit a patch:
https://wiki.postgresql.org/wiki/Submitting_a_Patch

You can have as well a look here to see how extensions like dblink are
structured:
http://www.postgresql.org/docs/devel/static/extend-pgxs.html
What you need to do in the case of your patch is to add necessary test
cases to in sql/dblink.sql for the new functions you have added and
then update the output in expected/. Be sure to not break any existing
things as well. After running the tests in your development
environment output results are available in results then pg_regress
generates a differential file in regressions.diffs.

For the documentation, updating dblink.sgml with the new function
prototypes would be sufficient. With perhaps an example(s) to show
that what you want to add is useful.
Regards,
--
Michael

pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: Redesigning checkpoint_segments
Next
From: Michael Paquier
Date:
Subject: Re: dblink: add polymorphic functions.