Postgres Pro
Downloads
Home   >   mailing lists

Re: Catching missing Datum conversions - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: Catching missing Datum conversions
Date
Msg-id CADkLM=dkgwFrXE0wh+yeHJbpv9ZzPNmL5SSC4jbFetzrnkcS+g@mail.gmail.com
Whole thread Raw
In response to Catching missing Datum conversions  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Tree view
I should probably split this into "actionable" (categories 3 and 4)
and "noise and scaffolding" patches.

Breaking down the noise-and-scaffolding into some subgroups might make the rather long patches more palatable/exceedingly-obvious:
* (Datum) 0 ---> NullDatum
* 0 ----> NullDatum
* The DatumGetPointer(allParameterTypes) null tests

Having said that, everything you did seems really straightforward, except for 
src/backend/rewrite/rewriteDefine.c
src/backend/statistics/mcv.c
src/backend/tsearch/ts_parse.c
and those seem like cases where the DatumGetXXX was a no-op before Datum was a struct.

pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Next
From: Tom Lane
Date:
Subject: Re: contrib make check-world fail if data have been modified and there's vpath