Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless) - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)
Date
Msg-id CADkLM=dKXVHn2pCx-JZqbsXb-fT7nn5LLebxTkmd3XPe4ayBdg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands:\quit_if, \quit_unless)  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Tree view
On Mon, Feb 13, 2017 at 3:04 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:

Hello Corey,

That effort was creating as many headaches as it solved. Rolled back v12 except for doc paragraph, added more descriptive tap test names. Enjoy.

 The TAP tests are missing from the patch, not sure why...

I went back to master and re-applied v11, something must have gotten lost in translation. 
 
The stack cleanup is nicer with pop calls.

Yeah, dunno why I didn't do that earlier.
 
Two debatable suggestions about the example:
 - put the on_error_stop as the very first thing in the example?
 - add a comment explaining what the SELECT ... \gset does?

Both are reasonable and easy. Added. 
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Removal of deprecated views pg_user, pg_group, pg_shadow
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Small improvement to parallel query docs