Re: [PATCH] pgpassfile connection option - Mailing list pgsql-hackers

From Mithun Cy
Subject Re: [PATCH] pgpassfile connection option
Date
Msg-id CAD__OuiyrBYsD_h-bLZN4Cb2GJNk7+uonm2g=fxoCGHbhansWA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pgpassfile connection option  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [PATCH] pgpassfile connection option
List pgsql-hackers
 > Independently of your patch, while testing I concluded that the multi-host feature and documentation should be improved:
 > - If a connection fails, it does not say for which host/port.

Thanks I will re-test same.

> In fact they are tried in turn if the network connection fails, but not
> if the connection fails for some other reason such as the auth.
> The documentation is not precise enough.

If we fail due to authentication, then I think we should notify the client instead of trying next host. I think it is expected genuine user have right credentials for making the connection. So it's better if we notify same to client immediately rather than silently ignoring them. Otherwise the host node which the client failed to connect will be permanently unavailable until client corrects itself. But I agree documentation and error message as you said need improvements. I will try to correct same.

--
Thanks and Regards
Mithun C Y

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: [RFC] Should we fix postmaster to avoid slow shutdown?
Next
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw : altering foreign table not invalidating prepare statement execution plan.