Re: "Some tests to cover hash_index" - Mailing list pgsql-hackers

From Mithun Cy
Subject Re: "Some tests to cover hash_index"
Date
Msg-id CAD__Oui56zrYz53ruS5TQSV8M=-yEiYZunqyHfUxRE7eGR3HhQ@mail.gmail.com
Whole thread Raw
In response to Re: "Some tests to cover hash_index"  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: "Some tests to cover hash_index"  (Amit Kapila <amit.kapila16@gmail.com>)
Re: "Some tests to cover hash_index"  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Sat, Aug 6, 2016 at 9:41 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> I wonder why you have included a new file for these tests, why can't be these added to existing hash_index.sql.
tests in hash_index.sql did not cover overflow pages, above tests were for mainly for them. So I thought having a separate test file can help enabling/disabling them in schedule files, when we do not want them running as it take slightly high time. If you think otherwise I will reconsider will add tests to hash_index.sql.

>The relation name con_hash_index* choosen in above tests doesn't seem to be appropriate, how about hash_split_heap* or something like that.
Fixed. Have renamed relation, index and test filename accordingly.

--
Thanks and Regards
Mithun C Y

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: PATCH: Keep one postmaster monitoring pipe per process
Next
From: Kenneth Marshall
Date:
Subject: Re: Hash Indexes