Re: [PATCH] Improve performance of NOTIFY over many databases (v2) - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: [PATCH] Improve performance of NOTIFY over many databases (v2)
Date
Msg-id CADWG95vnshiyHF5tKmeCD+k6fhQpRQJ3C6hKYqL78SO67CzivA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Improve performance of NOTIFY over many databases (v2)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Improve performance of NOTIFY over many databases (v2)
List pgsql-hackers
Hoi Tom,


On Wed, 11 Sep 2019 at 00:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:

I pushed 0001 after doing some hacking on it --- it was sloppy about
datatypes, and about whether the invalid-entry value is 0 or -1,
and it was just wrong about keeping the list in backendid order.
(You can't conditionally skip looking for where to put the new
entry, if you want to maintain the order.  I thought about just
defining the list as unordered, which would simplify joining the
list initially, but that could get pretty cache-unfriendly when
there are lots of entries.)

0002 is now going to need a rebase, so please do that.


Thanks for this, and good catch. Looks like I didn't test the first patch by itself very well.

Here is the rebased second patch.

Thanks in advance,
--
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: A problem presentaion about ECPG, DECLARE STATEMENT
Next
From: Fabien COELHO
Date:
Subject: Re: [patch]socket_timeout in interfaces/libpq