Re: Adding new dependencies for in-core - Mailing list pgsql-jdbc

From Dave Cramer
Subject Re: Adding new dependencies for in-core
Date
Msg-id CADK3HHKXFh1w9YJT4KHxLrabgvjmVB48C8F-4Yb=8ACtVddu5A@mail.gmail.com
Whole thread Raw
In response to Adding new dependencies for in-core  (Vladimir Sitnikov <sitnikov.vladimir@gmail.com>)
Responses Re: Adding new dependencies for in-core  (Vladimir Sitnikov <sitnikov.vladimir@gmail.com>)
List pgsql-jdbc
Hi Vladimir,

There are a large number of people still downloading jars, so simply using maven dependency doesn't work.

It would have to be shaded IMO.

This is why I have avoided dependencies in the past.

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 30 June 2015 at 08:21, Vladimir Sitnikov <sitnikov.vladimir@gmail.com> wrote:
Hi,

I've had a quick look into https://github.com/pgjdbc/pgjdbc/issues/345
(Share parsed query texts across different connections) and it looks
like https://github.com/ben-manes/concurrentlinkedhashmap would be
useful to implement the cache.

We don't need all the stuff CLHM has, but I see no easy&scalable way
of doing concurrent map with eviction by mere java.util.concurrent
stuff.

Well, I can do lock splitting (i.e. use multiple small LRU caches
instead of a single big cache), however that looks like reinventing
the wheel.

Can you suggest what is the best way of adding CLHM dependency?
Should it be added in plain?
Should it be shaded? (i.e. renamed to org.postgresql.clhm...)

I'm more inclined to the "add regular dependency" approach.

I expect similar question might appear if we consider using netty for IO.

--
Regards,
Vladimir Sitnikov


--
Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-jdbc

pgsql-jdbc by date:

Previous
From: Vladimir Sitnikov
Date:
Subject: Adding new dependencies for in-core
Next
From: Vladimir Sitnikov
Date:
Subject: Re: Adding new dependencies for in-core